Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Collect raw str values for new Tpl element #9261

Merged
merged 8 commits into from
Jul 17, 2024
Merged

fix(es/minifier): Collect raw str values for new Tpl element #9261

merged 8 commits into from
Jul 17, 2024

Conversation

stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Jul 16, 2024 •
edited
Loading

Description:
convert raw value to cooked for creating new Tpl element.

while optimizing nested tpl, after concatenating some cooked strs to assemble a new tpl element, the `raw` of the tpl should be escaped cooked string value.

BREAKING CHANGE:

None

Related issue (if exists):
#9184

@stormslowly stormslowly requested a review from a team as a code owner July 16, 2024 07:36
@kdy1 kdy1 added this to the Planned milestone Jul 16, 2024
@kdy1 kdy1 self-assigned this Jul 16, 2024
@stormslowly
Copy link
Contributor Author

@kdy1 Oops, a compress case failed, i am trying to fix

@stormslowly stormslowly changed the title fix(es/minifier): escape cooked string for raw value of new Tpl element wip: fix(es/minifier): escape cooked string for raw value of new Tpl element Jul 16, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9261 will not alter performance

Comparing stormslowly:fix/tpl_raw_un_escaped (9393acf) with main (baeb9e2)

Summary

✅ 178 untouched benchmarks

@stormslowly stormslowly changed the title wip: fix(es/minifier): escape cooked string for raw value of new Tpl element wip: fix(es/minifier): collect raw str values for new Tpl element Jul 16, 2024
@stormslowly stormslowly changed the title wip: fix(es/minifier): collect raw str values for new Tpl element fix(es/minifier): collect raw str values for new Tpl element Jul 16, 2024
@stormslowly stormslowly requested a review from kdy1 July 16, 2024 14:29
kdy1
kdy1 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_minifier --breaking

@kdy1 kdy1 enabled auto-merge (squash) July 17, 2024 05:49
@kdy1 kdy1 disabled auto-merge July 17, 2024 05:49
@kdy1 kdy1 changed the title fix(es/minifier): collect raw str values for new Tpl element fix(es/minifier): Collect raw str values for new Tpl element Jul 17, 2024
@kdy1 kdy1 merged commit 6ddbfa0 into swc-project:main Jul 17, 2024
155 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stormslowly @kdy1